cshannon commented on code in PR #3957:
URL: https://github.com/apache/accumulo/pull/3957#discussion_r1398245703
##########
server/manager/src/main/java/org/apache/accumulo/manager/TabletGroupWatcher.java:
##########
@@ -954,24 +999,32 @@ private void mergeMetadataRecords(MergeInfo info) throws
AccumuloException {
// delete any entries for external compactions
extCompIds.forEach(ecid ->
m.putDelete(ExternalCompactionColumnFamily.STR_NAME, ecid));
- if (!m.getUpdates().isEmpty()) {
- bw.addMutation(m);
- }
-
- bw.flush();
+ // Add a marker so we know the tablets have been fenced in case the
merge operation
+ // needs to be recovered and restarted to finish later. The value is
firstPrevRowValue
+ // which we need if we need to restart the operation
+ MergedColumnFamily.MERGED_COLUMN.put(m,
+ MergedColumnFamily.encodeHasPrevRowColumn(firstPrevRowValue !=
null));
Review Comment:
I think you are right that this wouldn't be null so we can get rid of this
and will make things much simpler as we just need to worry about the merge
marker existing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
