ctubbsii opened a new pull request, #3979:
URL: https://github.com/apache/accumulo/pull/3979

   * Use simpler expression for non-digits in regex pattern
   * Keep only the minimal code needed for the deprecated "chopped" column
   * Fix comment about version 3.1 (use dot, not comma)
   * Remove unnecessary 'var ignored = ' which caused unused variable warnings 
in some IDEs; this might cause warnings about unused return values in other 
IDEs, but I'm not sure the ideal way to address that at this point; for now, 
this change keeps us at 0 warnings in Eclipse with default settings, except 
those from thrift and the unavoidable ones from Eclipse's incorrect handling of 
forRemoval deprecations, and this is also consistent with our current coding 
style (we don't use ignored variable declarations anywhere else)
   * Make slight improvements to upgrader code to identify and retrieve the 
oldest upgradable version
   * Replace static imports to inner classes with non-static imports, as this 
results in the same code usage; static is unnecessary for these


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to