keith-turner commented on PR #4206:
URL: https://github.com/apache/accumulo/pull/4206#issuecomment-1919501931
I merged this branch into #3746 and resolved conflicts as a way of
reconciling the branches. The following are the major diffs I uncovered while
doing this.
* Why make accumulo access optional jar in the assemble pom?
* Should we deprecate ColumnVisibility.quote()? There are two instances of
that method (one for string and one for byte[]). This branch deprecates one of
those. When I merged I removed the single deprecation and threw in a TODO. If
we want to deprecate, thinking we should do both or neither.
* This branch had ColumnVis wrap and AccessExpression. In #3476 ColVis was
still wrapping a byte array instead of an AccessExpress. I kept the byte[] to
avoid going from byte[]->String->byte[] in some cases. Also avoid an extra
object allocation in some cases. However I am not sure about this. Wrapping
the AccessExpression seems cleaner, but may be inefficient in some
circumstances w/ more copies and object allocations.
* The existing changes in #3746 did not need to add a new List<byte[]>
constructor to AccessEvaluator, so I kept those. So if we want to keep those,
then may not need to add that method in accumulo-access.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
