keith-turner commented on code in PR #4229:
URL: https://github.com/apache/accumulo/pull/4229#discussion_r1480047615


##########
server/manager/src/main/java/org/apache/accumulo/manager/TabletGroupWatcher.java:
##########
@@ -513,7 +518,8 @@ private TableMgmtStats 
manageTablets(Iterator<TabletManagement> iter,
       }
 
       if (actions.contains(ManagementAction.NEEDS_SPLITTING)
-          && !actions.contains(ManagementAction.NEEDS_VOLUME_REPLACEMENT)) {
+          && !actions.contains(ManagementAction.NEEDS_VOLUME_REPLACEMENT)
+          && !actions.contains(ManagementAction.NEEDS_RECOVERY)) {

Review Comment:
   Based on this little section of code was thinking when 
NEEDS_VOLUME_REPLACEMENT or NEEDS_RECOVERY is set that the 
TabletManagementIterator iter could possibly skip checking for splits and 
compactions.  Not sure if that causes problems elsewhere though.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to