keith-turner opened a new issue, #4234:
URL: https://github.com/apache/accumulo/issues/4234

   TabletGroupWatcher will only check for volume replacement in the beginning 
of its lifetime based on [this 
check](https://github.com/apache/accumulo/blob/878e4edfeeb68622c2b13348220c521f1f36c091/server/manager/src/main/java/org/apache/accumulo/manager/TabletGroupWatcher.java#L683).
  The idea is that if it has scanned all tablets and saw no volume replacements 
then it no longer needs to look (because looking is expensive).  However, code 
like 
[this](https://github.com/apache/accumulo/blob/878e4edfeeb68622c2b13348220c521f1f36c091/server/manager/src/main/java/org/apache/accumulo/manager/TabletGroupWatcher.java#L401)
 could cause a tablet that needs volume replacement to not be examined.
   
   If the following code could somehow factor in if a full scan of all tablets 
was completed that would be useful.
   
   ```java
   // TODO ensure full scan w/o errors was completed somehow.
   lookForTabletsNeedingVolReplacement = 
tabletMgmtStats.totalVolumeReplacements != 0;
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to