keith-turner commented on code in PR #4238:
URL: https://github.com/apache/accumulo/pull/4238#discussion_r1483631520
##########
minicluster/src/test/java/org/apache/accumulo/minicluster/MiniAccumuloClusterTest.java:
##########
@@ -78,8 +78,10 @@ public static void setupMiniCluster() throws Exception {
MiniAccumuloConfig config = new MiniAccumuloConfig(testDir,
ROOT_PASSWORD).setJDWPEnabled(true);
config.setZooKeeperPort(0);
+ @SuppressWarnings("deprecation")
+ String workQThreadsProp = Property.TSERV_WORKQ_THREADS.getKey();
HashMap<String,String> site = new HashMap<>();
- site.put(Property.TSERV_WORKQ_THREADS.getKey(), "2");
+ site.put(workQThreadsProp, "2");
Review Comment:
This test probably does not care which prop is used ,so could switch to a
non deprecated prop.
```suggestion
site.put(Property.TSERV_COMPACTION_WARN_TIME.getKey(), "5m");
```
##########
minicluster/src/test/java/org/apache/accumulo/minicluster/MiniAccumuloClusterClasspathTest.java:
##########
@@ -79,8 +79,10 @@ public static void setupMiniCluster() throws Exception {
MiniAccumuloConfig config = new MiniAccumuloConfig(testDir,
ROOT_PASSWORD).setJDWPEnabled(true);
config.setZooKeeperPort(0);
+ @SuppressWarnings("deprecation")
+ String workQThreadsProp = Property.TSERV_WORKQ_THREADS.getKey();
HashMap<String,String> site = new HashMap<>();
- site.put(Property.TSERV_WORKQ_THREADS.getKey(), "2");
+ site.put(workQThreadsProp, "2");
Review Comment:
Seems like this could be removed, can not see how the test benefits from it.
```suggestion
```
##########
core/src/main/java/org/apache/accumulo/core/conf/Property.java:
##########
@@ -811,6 +811,7 @@ public enum Property {
+ " that begin with 'table.file' can be used here. For example, to
set the compression"
+ " of the sorted recovery files to snappy use
'tserver.wal.sort.file.compress.type=snappy'.",
"2.1.0"),
+ @Deprecated(since = "2.1.3")
TSERV_WORKQ_THREADS("tserver.workq.threads", "2", PropertyType.COUNT,
"The number of threads for the distributed work queue. These threads are"
+ " used for copying failed bulk import RFiles.",
Review Comment:
```suggestion
"The number of threads for the distributed work queue. These threads
are"
+ " used for copying failed bulk import RFiles. This property will
be removed when bulk import V1 is removed.",
```
##########
minicluster/src/test/java/org/apache/accumulo/minicluster/MiniAccumuloClusterTest.java:
##########
@@ -193,8 +195,10 @@ public void testDebugPorts() {
public void testConfig() {
// ensure what user passed in is what comes back
assertEquals(0, accumulo.getConfig().getZooKeeperPort());
+ @SuppressWarnings("deprecation")
+ String workQThreadsProp = Property.TSERV_WORKQ_THREADS.getKey();
HashMap<String,String> site = new HashMap<>();
- site.put(Property.TSERV_WORKQ_THREADS.getKey(), "2");
+ site.put(workQThreadsProp, "2");
Review Comment:
```suggestion
site.put(Property.TSERV_COMPACTION_WARN_TIME.getKey(), "5m");
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
