cshannon commented on code in PR #4204:
URL: https://github.com/apache/accumulo/pull/4204#discussion_r1484204556
##########
core/src/main/java/org/apache/accumulo/core/fate/AbstractFateStore.java:
##########
@@ -239,12 +254,46 @@ public int getDeferredCount() {
}
}
+ @Override
+ public FateId create(FateKey fateKey) {
+ FateId fateId = fateIdGenerator.fromTypeAndKey(getInstanceType(), fateKey);
Review Comment:
Very good catch, I plan to refactor the create method into
`Optional<FateTxStore<T>> createAndReserve(FateKey fateKey)` as suggested in
this
[comment](https://github.com/apache/accumulo/pull/4204#issuecomment-1934388313)
and can also make these changes as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
