DomGarguilo commented on PR #4242: URL: https://github.com/apache/accumulo/pull/4242#issuecomment-1944110457
@cshannon @keith-turner I added a test to make sure things only pass with push() when the expected statuses are present. This logic can be easily applied to the other methods as well. This was added in 73faa93df358732d8c11937f9ede655e9e162990. #4246 is tracking the effort to move the current test case in AccumuloStoreIT into FateStoreIT so it will run against both AccumuloStore and FateStore. The checks and tests added in this PR will push AccumuloStore and ZooStore a bit further apart in terms of what is checked. Do you think it is fine to keep things how they are now (adding these checks and tests for them) and then bringing ZooStore up to spec? Then we can move the test cases from AccumuloStoreIT into FateStoreIT. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
