dlmarion commented on code in PR #64:
URL: https://github.com/apache/accumulo-access/pull/64#discussion_r1496539569
##########
src/main/java/org/apache/accumulo/access/AccessEvaluator.java:
##########
@@ -88,12 +90,12 @@ static AccessEvaluator of(Authorizations authorizations) {
}
/**
- * Creates an AccessEvaluator from an Authorizer object
+ * Creates an AccessEvaluator from a Predicate<String>
Review Comment:
I wonder if we need a little more verbiage to explain when the predicate
should return true vs false. Given that this is part of the public API we may
want to explain that the AccessEvaluator implementation is going to call `test`
passing in a single Authorization and it should return true if the exact String
matches.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
