cshannon commented on code in PR #4404:
URL: https://github.com/apache/accumulo/pull/4404#discussion_r1535726287
##########
server/base/src/main/java/org/apache/accumulo/server/util/MetadataTableUtil.java:
##########
@@ -246,10 +250,19 @@ public static void deleteTable(TableId tableId, boolean
insertDeletes, ServerCon
public static void removeUnusedWALEntries(ServerContext context, KeyExtent
extent,
final Collection<LogEntry> entries, ServiceLock zooLock) {
- TabletMutator tablet = context.getAmple().mutateTablet(extent);
- entries.forEach(tablet::deleteWal);
- tablet.putZooLock(context.getZooKeeperRoot(), zooLock);
- tablet.mutate();
+ try (ConditionalTabletsMutator mutator =
context.getAmple().conditionallyMutateTablets()) {
+ ConditionalTabletMutator mut =
mutator.mutateTablet(extent).requireAbsentOperation()
Review Comment:
Edit: I meant to say in my previous post before I modified it that to add
that it should require NOT having the current zooLock since obviously it's
setting the current one, but that may not matter. I just noticed in the
rejection handler you were checking that the zooLock set equals the current
lock, so I was thinking we should require there not be a lock already when
submitting but this might not be necessary
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
