keith-turner commented on code in PR #4429:
URL: https://github.com/apache/accumulo/pull/4429#discussion_r1553962837
##########
server/tserver/src/main/java/org/apache/accumulo/tserver/TabletServer.java:
##########
@@ -532,15 +533,12 @@ public void enqueueManagerMessage(ManagerMessage m) {
managerMessages.addLast(m);
}
- void acquireRecoveryMemory(KeyExtent extent) {
- if (!extent.isMeta()) {
+ AutoCloseable acquireRecoveryMemory(TabletMetadata tabletMetadata) {
Review Comment:
I partially implemented this in 0a341af, only added NOOP_CLOSEABLE.
Thinking the case w/o walogs is the most frequent. The case w/ walogs is less
frequent and will already take a lot longer because of recovery so thought that
less code was better for that case over saving an object allocation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
