keith-turner commented on code in PR #4440:
URL: https://github.com/apache/accumulo/pull/4440#discussion_r1556033757


##########
server/manager/src/main/java/org/apache/accumulo/manager/tableOps/bulkVer2/LoadFiles.java:
##########
@@ -283,23 +293,25 @@ long finish() {
           results.values().stream().allMatch(result -> result.getStatus() == 
Status.ACCEPTED)
               && skipped == 0;
 
+      results.forEach((extent, condResult) -> {
+        if (condResult.getStatus() == Status.ACCEPTED) {
+          loadingFiles.get(extent).forEach(file -> 
TabletLogger.bulkImported(extent, file));
+        } else {
+          var metadata = condResult.readMetadata();
+          if (metadata == null) {
+            log.debug("Tablet update failed, tablet is gone {} {} {}", fateId, 
extent,
+                condResult.getStatus());
+          } else {
+            log.debug("Tablet update failed {} {} {} {} {} {}", fateId, extent,
+                condResult.getStatus(), metadata.getOperationId(), 
metadata.getLocation(),
+                metadata.getLoaded());
+          }
+        }
+      });
+

Review Comment:
   That is a nice improvement, updated in 48b6c83



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@accumulo.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to