dlmarion commented on code in PR #4421:
URL: https://github.com/apache/accumulo/pull/4421#discussion_r1557945817
##########
core/src/main/java/org/apache/accumulo/core/lock/ServiceLock.java:
##########
@@ -558,6 +558,11 @@ public synchronized void unlock() throws
InterruptedException, KeeperException {
LOG.debug("[{}] Deleting all at path {} due to unlock", vmLockPrefix,
pathToDelete);
ZooUtil.recursiveDelete(zooKeeper, pathToDelete, NodeMissingPolicy.SKIP);
+ // Wait for the delete to happen on the server before exiting method
+ while (zooKeeper.exists(pathToDelete, null) != null) {
Review Comment:
`ServiceLock.unlock`is only called from the server processes when they are
shutting down and from the tests. Not waiting for the locks to be removed
caused issues in tests where the cluster was restarted in between test methods.
I think for the tests we need to wait, but maybe I'll add some logging here so
that we know that the server is waiting to shutdown because the locks are not
removed. The user can then have the option to forcefully terminate the process
if they want.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
