keith-turner commented on code in PR #4445:
URL: https://github.com/apache/accumulo/pull/4445#discussion_r1561383603
##########
assemble/bin/accumulo-cluster:
##########
@@ -141,7 +141,7 @@ function control_service() {
ACCUMULO_SERVICE_INSTANCE=""
[[ $service == "tserver" && ${NUM_TSERVERS:-1} -gt 1 ]] &&
ACCUMULO_SERVICE_INSTANCE=${inst_id}
[[ $service == "compactor" ]] &&
ACCUMULO_SERVICE_INSTANCE="${inst_id}_${5}"
- [[ $service == "sserver" && ${NUM_SSERVERS:-1} -gt 1 ]] &&
ACCUMULO_SERVICE_INSTANCE=${inst_id}
+ [[ $service == "sserver" ]] && ACCUMULO_SERVICE_INSTANCE="${inst_id}_${5}"
Review Comment:
> We could simplify the code a bit more and only use the sserver1_<group> or
compactor1_<queue> patterns when there's more than one of each type.
There is one thing I like about always adding the `1` even if there is only
a single server and that is the log naming. If I start w/ a single server
process then I will get a log file w/o the `1`. If I change config to running
2 server process then I will get two logs files with numbers and the log file
w/o a number is abandoned.
I will take a stab at simplification.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
