ctubbsii commented on code in PR #422: URL: https://github.com/apache/accumulo-website/pull/422#discussion_r1569228138
########## _config.yml: ########## @@ -13,7 +13,7 @@ description: > # this means to ignore newlines until "url:" The Apache Accumulo™ sorted, distributed key/value store is a robust, scalable, high performance data storage and retrieval system. url: "https://accumulo.apache.org"; # the base hostname & protocol for your site -exclude: [vendor] +exclude: [/vendor, /.idea, /.git, /.github, /_site, /.sass-cache, /.jekyll-cache/, /.jekyll-metadata, /*.iml, /.bundle/, Dockerfile] Review Comment: On https://jekyllrb.com/docs/configuration/options/ , it says that specifying this overrides the default excludes in Jekyll 3, but gets added to the defaults in Jekyll 4. We require at least Jekyll 4.2, so this doesn't need to specify anything already included in the defaults (which are also listed on that page). In the docs for `include`, it also says dotfiles are excluded by default, but I don't see that specified in the docs for `exclude`, so it's probably out of date. I would remove any entries here that are in the default list. Also, remove `_site`, because that is the output directory, and changes there should be handled correctly by jekyll automatically (and detecting changes might actually be important for incremental builds). The jekyll metadata and bundle directories and Dockerfile shouldn't change much, so I think those can be excluded, too. I don't think the IDE files need to be added, because those files are probably not changing much unless you're editing the files themselves (also, I don't think it's common to use an IDE for the website). Honestly, I would probably just delete this line entirely, and leave it to the defaults. I don't think we're doing anything so special here as to need to override this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@accumulo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
