DomGarguilo commented on code in PR #4513: URL: https://github.com/apache/accumulo/pull/4513#discussion_r1604996581
########## test/src/main/java/org/apache/accumulo/test/ServerVersionIT.java: ########## @@ -0,0 +1,88 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * https://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.accumulo.test; + +import static org.junit.jupiter.api.Assertions.assertThrows; +import static org.junit.jupiter.api.Assertions.assertTrue; + +import java.io.File; +import java.io.IOException; +import java.util.concurrent.ExecutorService; +import java.util.concurrent.Executors; +import java.util.concurrent.Future; +import java.util.concurrent.TimeUnit; +import java.util.concurrent.TimeoutException; + +import org.apache.accumulo.harness.SharedMiniClusterBase; +import org.apache.accumulo.minicluster.ServerType; +import org.apache.accumulo.server.AccumuloDataVersion; +import org.apache.accumulo.server.fs.VolumeManager; +import org.apache.hadoop.fs.FileSystem; +import org.apache.hadoop.fs.Path; +import org.junit.jupiter.api.AfterAll; +import org.junit.jupiter.api.BeforeAll; +import org.junit.jupiter.api.Test; + +public class ServerVersionIT extends SharedMiniClusterBase { + + @BeforeAll + public static void setup() throws Exception { + startMiniCluster(); + } + + @AfterAll + public static void tearDown() { + stopMiniCluster(); + } + + @Test + public void test() throws Exception { + File root = getCluster().getConfig().getAccumuloDir(); + String path = root + "/version/"; + Path rootPath = new Path(path + AccumuloDataVersion.get()); + FileSystem fs = getCluster().getFileSystem(); + VolumeManager vm = getCluster().getServerContext().getVolumeManager(); + + assertTrue(fs.exists(rootPath)); + + getCluster().stop(); + + // Create a new Path to simulate accumulo update + Path newPath = new Path(path + AccumuloDataVersion.get() + 1); + vm.create(newPath); + + // Start the procs + ExecutorService executor = Executors.newSingleThreadExecutor(); + Future<?> future = executor.submit(() -> { + for (ServerType st : ServerType.values()) { + try { + getCluster().getClusterControl().start(st); + } catch (IOException e) { + throw new RuntimeException(e); + } + } + }); + // Check to see if servers fail to start + assertThrows(TimeoutException.class, () -> future.get(20, TimeUnit.SECONDS)); + + // Check to see if both paths exist at the sametime + assertTrue(fs.exists(rootPath)); + assertTrue(fs.exists(newPath)); Review Comment: Might be better to move this check before we check for the timeout -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@accumulo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
