EdColeman commented on PR #4572: URL: https://github.com/apache/accumulo/pull/4572#issuecomment-2125817768
The process name and IP are set as common tags when the metrics are initialized and do not need to be added again. Common tags cannot be added once the metrics are initialized, but you could add custom tags when you create the meter if there is a need to differentiate a metric. Adding a custom tag would be appropriate when it makes sense if multiple meters could be rolled up into and presented as a single metric. Say something was like response.time and there were individual components that make up that value. Using a tag like "client.a", "client.b" would let the overall response.time to be presented by the metrics collection / display - and still allow the ability to drill down to the component if needed. If they do not make sense rolled up, then using a unique name for each meter would probably be better, -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@accumulo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
