gwynlionhart commented on PR #4580: URL: https://github.com/apache/accumulo/pull/4580#issuecomment-2127049211
Thanks, I gave it a shot through tests and it looks fine. Regarding a test on whether the serialization contains a password, I wrote a small one: ``` @Test public void deserializesWithoutPassword() throws Exception { CredentialProviderToken token = new CredentialProviderToken("bob.password", keystorePath); String serializedTokenString = new String(AuthenticationToken.AuthenticationTokenSerializer.serialize(token)); assertFalse(serializedTokenString.contains(new String(token.getPassword()))); } ``` You'd have to make a jceks file where the password value doesn't contain any string from the JCEKS alias. My test fails for me because the passwords.jceks values all have the word "password" in the alias name with a password "password". But visually inspecting the serialized string and it no longer displays the password. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@accumulo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org