ddanielr commented on code in PR #4592:
URL: https://github.com/apache/accumulo/pull/4592#discussion_r1611751752
##########
core/src/main/java/org/apache/accumulo/core/spi/balancer/HostRegexTableLoadBalancer.java:
##########
@@ -518,6 +518,8 @@ public long balance(BalanceParameters params) {
migrationsOut.addAll(newMigrations);
if (migrationsOut.size() >= myConf.maxTServerMigrations) {
+ LOG.warn("Table {} migration size : {} is over tserver migration max:
{}", tableId,
Review Comment:
> I'm wondering if this should be `debug` instead of `warn`. I think the
code will process this batch of migrations because it's exceeded the batch
size, but I'm pretty sure that it will come right back to this code and get the
migrations for the rest of the tables.
We could drop it to debug as the information is still valuable when
troubleshooting migration delay issues.
> Could this end up being a spammy message?
At warn it could be spammy in the monitor as it would pop out on every
migration run.
The current logs are extremely spammy if migrations are happening so I don't
think it would be noticed at the debug level.
##########
core/src/main/java/org/apache/accumulo/core/spi/balancer/HostRegexTableLoadBalancer.java:
##########
@@ -518,6 +518,8 @@ public long balance(BalanceParameters params) {
migrationsOut.addAll(newMigrations);
if (migrationsOut.size() >= myConf.maxTServerMigrations) {
+ LOG.warn("Table {} migration size : {} is over tserver migration max:
{}", tableId,
Review Comment:
> I'm wondering if this should be `debug` instead of `warn`. I think the
code will process this batch of migrations because it's exceeded the batch
size, but I'm pretty sure that it will come right back to this code and get the
migrations for the rest of the tables.
We could drop it to debug as the information is still valuable when
troubleshooting migration delay issues.
> Could this end up being a spammy message?
At warn it could be spammy in the monitor as it would pop out on every
migration run.
The current logs are extremely spammy if migrations are happening so I don't
think it would be noticed at the debug level.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
