EdColeman commented on code in PR #4535:
URL: https://github.com/apache/accumulo/pull/4535#discussion_r1617617227


##########
core/src/main/java/org/apache/accumulo/core/clientImpl/TabletServerBatchReader.java:
##########
@@ -71,9 +72,9 @@ protected TabletServerBatchReader(ClientContext context, 
Class<?> scopeClass, Ta
     this.tableName = tableName;
     this.numThreads = numQueryThreads;
 
-    queryThreadPool =
-        context.threadPools().getPoolBuilder("batch scanner " + 
batchReaderInstance + "-")
-            .numCoreThreads(numQueryThreads).build();
+    queryThreadPool = context.threadPools()
+        .getPoolBuilder(METRICS_POOL_PREFIX + "tserver.batch.reader.scanner" + 
batchReaderInstance)

Review Comment:
   Fixed in 21aa29c435



##########
core/src/main/java/org/apache/accumulo/core/clientImpl/bulk/BulkImport.java:
##########
@@ -482,12 +484,16 @@ private SortedMap<KeyExtent,Bulk.Files> 
computeMappingFromFiles(FileSystem fs, T
     if (this.executor != null) {
       executor = this.executor;
     } else if (numThreads > 0) {
-      executor = service = 
context.threadPools().getPoolBuilder("BulkImportThread")
-          .numCoreThreads(numThreads).build();
+      executor = service =
+          context.threadPools().getPoolBuilder(METRICS_POOL_PREFIX + 
"bulk.import.service")

Review Comment:
   Fixed in 21aa29c435



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@accumulo.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to