keith-turner commented on code in PR #4730:
URL: https://github.com/apache/accumulo/pull/4730#discussion_r1670776452
##########
server/tserver/src/main/java/org/apache/accumulo/tserver/tablet/CompactableImpl.java:
##########
@@ -1281,6 +1281,10 @@ private Optional<CompactionInfo>
reserveFilesForCompaction(CompactionServiceId s
cInfo.localHelper = this.chelper;
cInfo.localCompactionCfg = this.compactionConfig;
+ // don't include execution hints, which may have been previously set,
for system compactions
+ if (job.getKind() == CompactionKind.SYSTEM) {
+ cInfo.localCompactionCfg.setExecutionHints(Collections.emptyMap());
Review Comment:
`cInfo.localCompactionCfg` is a reference to `this.compactionConfig` so
changing it will change `this.compactionConfig` which could cause bugs with
user compactions.
`cInfo.localCompactionCfg` really only needs to be logged for user
compactions. One way to achieve this is to only set `cInfo.localCompactionCfg`
for user compactions and have it be null otherwise. This would log null for
the config for non user compactions
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
