meatballspaghetti opened a new pull request, #4745:
URL: https://github.com/apache/accumulo/pull/4745
This PR is meant to delete the `MutableByteSequence` class which was used by
4 files: `RFile`, `LocalityGroupUtil`, `RelativeKey`, and `RelativeKeyTest`.
Upon deleting the class, its usages were replaced with
`forMutableByteSequence()`, a static named constructor in `ArrayByteSequence`
which maintains the functionality from previous `MutableByteSequence` objects.
The following files have been modified:
-
`core/src/main/java/org/apache/accumulo/core/util/MutableByteSequence.java`:
Deleted.
- `core/src/main/java/org/apache/accumulo/core/data/ArrayByteSequence.java`:
Migrate byte sequence modification methods from `MutableByteSequence`. Create
`forMutableByteSequence()` method, a static named constructor to replace the
functionality of previous `MutableByteSequence` objects. Functionality included:
- Creates a `ArrayByteSequence` object
- Disallows `ArrayByteSequence` objects from being modified, effectively
maintaining their immutability, unless they were created by
`forMutableByteSequence()` constructor
- `core/src/main/java/org/apache/accumulo/core/file/rfile/RFile.java`,
`core/src/main/java/org/apache/accumulo/core/file/rfile/RelativeKey.java`,
`core/src/main/java/org/apache/accumulo/core/util/LocalityGroupUtil.java`,
and
`core/src/test/java/org/apache/accumulo/core/file/rfile/RelativeKeyTest.java`
have each had their previous references to `MutableByteSequence` replaced
with new `forMutableByteSequence()` constructor.
Fixes #4738 "Look at collapsing MutableByteSequence into ArrayByteSequence"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
