ctubbsii commented on code in PR #4731:
URL: https://github.com/apache/accumulo/pull/4731#discussion_r1689474165
##########
server/manager/src/main/java/org/apache/accumulo/manager/ManagerClientServiceHandler.java:
##########
@@ -555,10 +555,13 @@ private void alterTableProperty(TCredentials c, String
tableName, String propert
}
try {
- if (value == null || value.isEmpty()) {
+ if (op == TableOperation.REMOVE_PROPERTY) {
PropUtil.removeProperties(manager.getContext(),
TablePropKey.of(manager.getContext(), tableId), List.of(property));
- } else {
+ } else if (op == TableOperation.SET_PROPERTY) {
+ if (value == null || value.isEmpty()) {
Review Comment:
It probably shouldn't be possible for most properties to set it to a
non-empty string of whitespace. So, `value.isBlank()` might be better. However,
I don't want to make assumptions about what custom properties or SPI opts
properties might do, so probably best to leave it alone. This is good.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
