keith-turner commented on code in PR #4748:
URL: https://github.com/apache/accumulo/pull/4748#discussion_r1707979216
##########
core/src/main/java/org/apache/accumulo/core/data/ByteSequence.java:
##########
@@ -157,4 +185,85 @@ public int hashCode() {
return hash;
}
+ /**
+ * This method returns an empty immutable byte sequence. The same object is
always returned.
+ *
+ * @since 3.1.0
+ */
+ public static ByteSequence of() {
+ return EmptyByteSequence.INSTANCE;
Review Comment:
Currently ImmutableByteSequence is package private. Was loosely following
the pattern of the java `of` methods on collections where the concrete type
they might return is not public. Do you think ImmutableByteSequence should be
made public?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
