kevinrr888 commented on code in PR #4816:
URL: https://github.com/apache/accumulo/pull/4816#discussion_r1744650156
##########
core/src/main/java/org/apache/accumulo/core/iterators/IteratorEnvironment.java:
##########
@@ -52,16 +52,16 @@ default AccumuloConfiguration getConfig() {
}
/**
- * Return the executed scope of the Iterator. Value will be one of the
following:
- * {@link IteratorScope#scan}, {@link IteratorScope#minc}, {@link
IteratorScope#majc}
+ * @return the executed scope of the Iterator. Value will be one of the
following:
+ * {@link IteratorScope#scan}, {@link IteratorScope#minc}, {@link
IteratorScope#majc}
*/
default IteratorScope getIteratorScope() {
throw new UnsupportedOperationException();
}
/**
- * Return true if the compaction is a full major compaction. Will throw
IllegalStateException if
- * {@link #getIteratorScope()} != {@link IteratorScope#majc}.
+ * @return true if the compaction is a full major compaction; false otherwise
+ * @throws IllegalStateException if {@link #getIteratorScope()} != {@link
IteratorScope#majc}.
Review Comment:
I hadn't looked into why an exception was thrown, I had just kept the
functionality the same and consistent across impls. I assumed there was
probably a reason for wanting all impls to throw an exception and didn't look
any further.
Are you suggesting to drop the documentation about the exception case and
revert the changes I made to adhere to the exception case, or are you
suggesting changing the functionality to no longer throw the exception, or
something else?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
