keith-turner commented on code in PR #5025:
URL: https://github.com/apache/accumulo/pull/5025#discussion_r1824809634
##########
core/src/main/java/org/apache/accumulo/core/conf/Property.java:
##########
@@ -314,6 +314,13 @@ public enum Property {
"Enables additional JVM metrics collection and reporting using
Micrometer. Requires "
+ "property 'general.micrometer.enabled' to be set to 'true' to take
effect.",
"2.1.0"),
+
GENERAL_MICROMETER_LOG_METRICS_ENABLED("general.micrometer.log.metrics.enabled",
"none",
Review Comment:
Could drop the word enabled from the end of the prop name because that word
makes it sound like the values should be a boolean.
```suggestion
GENERAL_MICROMETER_LOG_METRICS("general.micrometer.log.metrics", "none",
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
