keith-turner commented on code in PR #5026:
URL: https://github.com/apache/accumulo/pull/5026#discussion_r1824820949


##########
core/src/main/java/org/apache/accumulo/core/util/compaction/CompactionJobPrioritizer.java:
##########
@@ -44,6 +49,11 @@ public static short createPriority(CompactionKind kind, int 
totalFiles, int comp
         return (short) prio;
       case SELECTOR:
       case SYSTEM:
+        // Given that tablets with too many files cause several problems,
+        // boost their priority to the maximum allowed value.
+        if (condition == Condition.TABLET_OVER_SIZE) {
+          return Short.MAX_VALUE;

Review Comment:
   If this change were made in 4.0 then could add a third min max range to the 
following code
   
   
https://github.com/apache/accumulo/blob/7673a666899d82ee6e2f3e595fb55c688edee4f3/core/src/main/java/org/apache/accumulo/core/util/compaction/CompactionJobPrioritizer.java#L94-L100



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to