keith-turner commented on code in PR #5070:
URL: https://github.com/apache/accumulo/pull/5070#discussion_r1844267672
##########
server/manager/src/main/java/org/apache/accumulo/manager/Manager.java:
##########
@@ -1057,11 +1059,29 @@ private long balanceTablets() {
int attemptNum = 0;
do {
log.debug("Balancing for tables at level {}, times-in-loop: {}", dl,
++attemptNum);
- params = BalanceParamsImpl.fromThrift(tserverStatusForBalancerLevel,
- tserverStatusForLevel, partitionedMigrations.get(dl));
+
+ SortedMap<TabletServerId,TServerStatus> statusForBalancerLevel =
+ tserverStatusForBalancerLevel;
+ if (attemptNum % checkInterval == 0) {
Review Comment:
It may be that the best way to balance by level in 2.1 is inside a balancer
plugin. Not sure, but maybe doing this at the manager level requires changes
to the SPI which would be best done in a 2.2, 3.1, or 4.0. Not sure though.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
