keith-turner commented on code in PR #5071:
URL: https://github.com/apache/accumulo/pull/5071#discussion_r1845256398
##########
server/manager/src/main/java/org/apache/accumulo/manager/split/Splitter.java:
##########
@@ -191,6 +186,29 @@ public FileInfo getCachedFileInfo(TableId tableId,
TabletFile tabletFile) {
}
public void initiateSplit(SeedSplitTask seedSplitTask) {
- splitExecutor.execute(seedSplitTask);
+ // Want to avoid queuing the same tablet multiple times, it would not
cause bugs but would waste
+ // work. Use the metadata row to identify a tablet because the KeyExtent
also includes the prev
+ // end row which may change when splits happen. The metaRow is
conceptually tableId+endRow and
+ // that does not change for a split.
+ Text metaRow = seedSplitTask.getExtent().toMetaRow();
+ int qsize = queuedTablets.size();
+ if (qsize < 10_000 && queuedTablets.add(metaRow)) {
Review Comment:
Not sure if will need to be configurable, would like to wait for a need
before making it configurable. Seems like if it was configurable it would need
metrics or log messages that help when changing the config.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
