dlmarion commented on code in PR #5072:
URL: https://github.com/apache/accumulo/pull/5072#discussion_r1846982146
##########
core/src/main/java/org/apache/accumulo/core/client/admin/InstanceOperations.java:
##########
@@ -312,6 +312,10 @@ List<ActiveCompaction> getActiveCompactions(ServerId
server)
*/
List<ActiveCompaction> getActiveCompactions() throws AccumuloException,
AccumuloSecurityException;
+ List<ActiveCompaction> getActiveCompactions(Predicate<String>
resourceGroupPredicate,
Review Comment:
This is going to need javadoc with a `@since` tag
##########
shell/src/main/java/org/apache/accumulo/shell/commands/ListCompactionsCommand.java:
##########
@@ -85,10 +90,14 @@ public Options getOptions() {
filterOption = new Option("f", "filter", true, "show only compactions that
match the regex");
opts.addOption(filterOption);
- tserverOption = new Option("ts", "tabletServer", true,
- "tablet server or compactor to list compactions for");
- tserverOption.setArgName("tablet server");
- opts.addOption(tserverOption);
+ serverOpt = new Option("s", "server", true, "tablet/scan server regex to
list compactions for");
Review Comment:
same comment applies here
##########
shell/src/main/java/org/apache/accumulo/shell/commands/ListScansCommand.java:
##########
@@ -75,14 +77,31 @@ public int numArgs() {
public Options getOptions() {
final Options opts = new Options();
- tserverOption = new Option("ts", "tabletServer", true, "tablet server to
list scans for");
- tserverOption.setArgName("tablet server");
- opts.addOption(tserverOption);
+ serverOpt = new Option("s", "server", true, "tablet/scan server regex to
list scans for");
Review Comment:
In #4958 I left the `ts` parameter and made it work for all types. I also
added a `s` parameter which does the same thing. My thinking was that then
users would not have to fix any scripts that they have written. I would suggest
that we have a common approach to this, so either you do the same here, or we
remove `ts` from PingCommand.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
