dlmarion commented on code in PR #5030:
URL: https://github.com/apache/accumulo/pull/5030#discussion_r1847100531
##########
server/tserver/src/main/java/org/apache/accumulo/tserver/metrics/TabletServerMetrics.java:
##########
@@ -63,8 +81,55 @@ private long getTotalEntriesWritten() {
return FileCompactor.getTotalEntriesWritten();
}
+ public static class TableMetrics {
Review Comment:
I did some digging to see if Micrometer had any support for dynamic tags. I
found https://github.com/micrometer-metrics/micrometer/pull/4097, which
essentially allows you to create templates for Meters, then these get
registered when you supply the tags. I'm wondering if you had seen this, and
if not, if it would change your implementation here. I'm thinking we could
create the templates (MeterProvider in Micrometer) when the servers start up,
then just apply and remove based on the table id tags.
##########
pom.xml:
##########
@@ -169,7 +169,7 @@
<dependency>
<groupId>io.micrometer</groupId>
<artifactId>micrometer-bom</artifactId>
- <version>1.12.2</version>
+ <version>1.13.6</version>
Review Comment:
FYI that some things will have to change down in the accumulo-testing
Terraform contrib code when this is merged due to the version change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
