dlmarion commented on PR #5074: URL: https://github.com/apache/accumulo/pull/5074#issuecomment-2491115776
> Seems like the three metric names in this PR could use the `accumulo.compaction` prefix like in #5075. Like `accumulo.compaction.majc.queued`. I merged into #5075 and fixed the names here. Also not something for this PR, but it seems like `MAJC_QUEUED` and `MAJC_RUNNING` could be removed. Those two metrics are dupicating data the is present in per compactor RG metrics and could be derived from those. `CompactionCoordinator.registerMetrics` registers `MAJC_QUEUED` and `MAJC_RUNNING`. I see that QueueMetrics registers `COMPACTOR_JOB_PRIORITY_QUEUE_JOBS_QUEUED` with a `queue.id` tag, which could be summed up to replace `MAJC_QUEUED`. I don't see a direct replacement for `MAJC_RUNNING` though. What did you have in mind for that? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
