kevinrr888 commented on code in PR #5028:
URL: https://github.com/apache/accumulo/pull/5028#discussion_r1852513750
##########
core/src/main/java/org/apache/accumulo/core/fate/AbstractFateStore.java:
##########
@@ -275,6 +269,10 @@ protected void verifyFateKey(FateId fateId,
Optional<FateKey> fateKeySeen,
"Collision detected for fate id " + fateId);
}
+ protected void verifyLock(ZooUtil.LockID lockID, FateId fateId) {
Review Comment:
Yeah, it is redundant but, like you said, I thought it might be better to
have the more detailed error message at the cost of double-checking the lock id
for null
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
