cshannon commented on code in PR #5102:
URL: https://github.com/apache/accumulo/pull/5102#discussion_r1855529795
##########
core/src/main/java/org/apache/accumulo/core/clientImpl/InstanceOperationsImpl.java:
##########
@@ -265,33 +269,17 @@ public List<String> getTabletServers() {
@Deprecated(since = "4.0.0")
public List<ActiveScan> getActiveScans(String tserver)
throws AccumuloException, AccumuloSecurityException {
- final var parsedTserver = HostAndPort.fromString(tserver);
- TabletScanClientService.Client client = null;
- try {
- client = getClient(ThriftClientTypes.TABLET_SCAN, parsedTserver,
context);
-
- List<ActiveScan> as = new ArrayList<>();
- for (var activeScan : client.getActiveScans(TraceUtil.traceInfo(),
context.rpcCreds())) {
- try {
- as.add(new ActiveScanImpl(context, activeScan));
- } catch (TableNotFoundException e) {
- throw new AccumuloException(e);
- }
- }
- return as;
- } catch (ThriftSecurityException e) {
- throw new AccumuloSecurityException(e.user, e.code, e);
- } catch (TException e) {
- throw new AccumuloException(e);
- } finally {
- if (client != null) {
- returnClient(client, context);
- }
- }
+ ServerId si = getServerId(tserver);
Review Comment:
Oops, good catch, I didn't pay close enough attention to that when I was
refactoring and trying to use a common method.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
