dlmarion commented on code in PR #5099:
URL: https://github.com/apache/accumulo/pull/5099#discussion_r1856891073
##########
assemble/bin/accumulo-cluster:
##########
@@ -651,28 +639,46 @@ function main() {
fi
cat <<EOF >"$conf"/cluster.yaml
manager:
- - localhost
+ default:
+ conf_dir: /opt/accumulo/conf
+ extra_args: ""
+ hosts:
+ - localhost
monitor:
- - localhost
+ default:
+ conf_dir: /opt/accumulo/conf
+ extra_args: ""
+ hosts:
+ - localhost
gc:
- - localhost
+ default:
+ conf_dir: /opt/accumulo/conf
+ extra_args: ""
Review Comment:
> Could possibly have a `jvm_args` in the future.
Looking at `accumulo-env.sh`, a user can supply `ACCUMULO_JAVA_OPTS`
environment variable to add arguments to the JVM. However, this is added before
most of the arguments, not after. So, for example, setting a JVM Xmx size in
the cluster.yaml file to override the accumulo-env.sh file, would not work. If
the user wants to specify some arguments that are not in the accumulo-env.sh
file at all, then that would likely work.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
