kevinrr888 commented on PR #5214: URL: https://github.com/apache/accumulo/pull/5214#issuecomment-2610043065
@dlmarion I was holding off on re-reviewing that until this received approval, that way we could better decide what the backport would look like. I looked over the merged PR, and it seems it is missing an interleaving test. `testDefaultInterleaving` is the only test but that only has ops with `isReady()` calls which always return 0, so interleaving will never occur. Is there a reason not to include an interleaving test in 3.1? Also, I think https://github.com/apache/accumulo/pull/5223#discussion_r1901940835 would still be important to include to ensure `isReady()` calls always come before `call()` calls. > I merged https://github.com/apache/accumulo/pull/5223 into 3.1, then I removed the FateExecutionOrderIT file on the merge to main. Please rename FateInterleavingIT to FateExecutionOrderIT in this PR. Thank you, I have renamed it in this PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@accumulo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
