ddanielr commented on code in PR #5341:
URL: https://github.com/apache/accumulo/pull/5341#discussion_r1965208571
##########
server/manager/src/main/java/org/apache/accumulo/manager/tableOps/bulkVer2/LoadFiles.java:
##########
@@ -339,11 +338,21 @@ private long loadFiles(TableId tableId, Path bulkDir,
LoadMappingIterator loadMa
loader.start(bulkDir, manager, tid, bulkInfo.setTime);
long t1 = System.currentTimeMillis();
+ KeyExtent prevLastExtent = null; // KeyExtent of last tablet from prior
loadMapEntry
while (lmi.hasNext()) {
loadMapEntry = lmi.next();
- List<TabletMetadata> tablets =
findOverlappingTablets(loadMapEntry.getKey(), tabletIter);
+ KeyExtent loadMapKey = loadMapEntry.getKey();
+ if (prevLastExtent != null &&
!loadMapKey.isPreviousExtent(prevLastExtent)) {
+ tm.close();
+ tm = TabletsMetadata.builder(manager.getContext()).forTable(tableId)
Review Comment:
There's a very similar block of code that is creating a TabletsMetadata
object in the earlier `PrepBulkImport` class.
https://github.com/apache/accumulo/blob/e776715d8763309cffa314d14d3c2c41584b6402/server/manager/src/main/java/org/apache/accumulo/manager/tableOps/bulkVer2/PrepBulkImport.java#L208-L210
##########
server/manager/src/main/java/org/apache/accumulo/manager/tableOps/bulkVer2/LoadFiles.java:
##########
@@ -339,11 +338,21 @@ private long loadFiles(TableId tableId, Path bulkDir,
LoadMappingIterator loadMa
loader.start(bulkDir, manager, tid, bulkInfo.setTime);
long t1 = System.currentTimeMillis();
+ KeyExtent prevLastExtent = null; // KeyExtent of last tablet from prior
loadMapEntry
while (lmi.hasNext()) {
loadMapEntry = lmi.next();
- List<TabletMetadata> tablets =
findOverlappingTablets(loadMapEntry.getKey(), tabletIter);
+ KeyExtent loadMapKey = loadMapEntry.getKey();
+ if (prevLastExtent != null &&
!loadMapKey.isPreviousExtent(prevLastExtent)) {
+ tm.close();
+ tm = TabletsMetadata.builder(manager.getContext()).forTable(tableId)
Review Comment:
It is doing something differently So I don't know if it would really benefit
from this code change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
