kevinrr888 commented on code in PR #5348: URL: https://github.com/apache/accumulo/pull/5348#discussion_r1965730131
########## test/src/main/java/org/apache/accumulo/test/AdminCheckIT.java: ########## @@ -34,19 +35,29 @@ import java.util.Set; import java.util.TreeMap; import java.util.function.Supplier; -import java.util.regex.Pattern; Review Comment: General comment about `AdminCheckIT`: considered changing from ConfigurableMacBase to SharedMiniCluserBase for this test from suggestion of @dlmarion. Prior to these new changes, SharedMiniClusterBase was sufficient and much faster, but some of these tests now do damage to the MAC to test for failure cases of the checks (e.g., deleting essential files, messing with metadata), so stuck with ConfigurableMacBase -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
