dlmarion commented on code in PR #5355:
URL: https://github.com/apache/accumulo/pull/5355#discussion_r1970649047
##########
server/manager/src/main/java/org/apache/accumulo/manager/tableOps/bulkVer2/LoadFiles.java:
##########
@@ -328,25 +365,19 @@ private long loadFiles(TableId tableId, Path bulkDir,
LoadMappingIterator loadMa
String fmtTid = FateTxId.formatTid(tid);
log.trace("{}: Starting bulk load at row: {}", fmtTid, startRow);
- Iterator<TabletMetadata> tabletIter =
-
TabletsMetadata.builder(manager.getContext()).forTable(tableId).overlapping(startRow,
null)
- .checkConsistency().fetch(PREV_ROW, LOCATION,
LOADED).build().iterator();
+ loader.start(bulkDir, manager, tid, bulkInfo.setTime);
+ long t1 = System.currentTimeMillis();
- Loader loader;
- if (bulkInfo.tableState == TableState.ONLINE) {
- loader = new OnlineLoader();
- } else {
- loader = new OfflineLoader();
- }
+ try (TabletsMetadata tabletsMetadata =
factory.newTabletsMetadata(startRow)) {
Review Comment:
I removed the close method on the interface in b217cfe
##########
server/manager/src/main/java/org/apache/accumulo/manager/tableOps/bulkVer2/LoadFiles.java:
##########
@@ -80,6 +79,14 @@
*/
class LoadFiles extends ManagerRepo {
+ // visible for testing
+ interface TabletsMetadataFactory {
+
+ TabletsMetadata newTabletsMetadata(Text startRow);
+
+ void close();
Review Comment:
Removed in b217cfe.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
