dlmarion commented on code in PR #5357:
URL: https://github.com/apache/accumulo/pull/5357#discussion_r1971821495


##########
core/src/main/java/org/apache/accumulo/core/Constants.java:
##########
@@ -84,6 +84,8 @@ public class Constants {
   public static final String ZHDFS_RESERVATIONS = "/hdfs_reservations";
   public static final String ZRECOVERY = "/recovery";
 
+  public static final String ZUPGRADE_STATUS = "/upgrade_status";

Review Comment:
   Addressed in 7d19a91



##########
server/manager/src/main/java/org/apache/accumulo/manager/upgrade/UpgradeCoordinator.java:
##########
@@ -173,13 +174,22 @@ public synchronized void upgradeZookeeper(ServerContext 
context,
       if (currentVersion < AccumuloDataVersion.get()) {
         abortIfFateTransactions(context);
 
+        final ComponentVersions tracker = UpgradeProgressTracker.get(context);
+
         for (int v = currentVersion; v < AccumuloDataVersion.get(); v++) {
+          if (tracker.getZooKeeperVersion() >= currentVersion) {

Review Comment:
   Addressed in 7d19a91



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to