dlmarion commented on code in PR #5383:
URL: https://github.com/apache/accumulo/pull/5383#discussion_r1989498427
##########
test/src/main/java/org/apache/accumulo/test/upgrade/UpgradeProgressTrackerIT.java:
##########
@@ -139,8 +139,7 @@ public void testUpgradeAlreadyStarted() throws
KeeperException, InterruptedExcep
zk.create(zRoot + Constants.ZUPGRADE_PROGRESS,
GSON.get().toJson(progress).getBytes(UTF_8),
ZooUtil.PUBLIC, CreateMode.PERSISTENT);
assertTrue(upgradeNodeExists());
- var ise =
- assertThrows(IllegalStateException.class, () ->
progressTracker.startOrContinueUpgrade());
+ var ise = assertThrows(IllegalStateException.class, () ->
progressTracker.continueUpgrade());
assertTrue(ise.getMessage()
.startsWith("Upgrade was already started with a different version of
software"));
var npe = assertThrows(NullPointerException.class, () ->
progressTracker.getProgress());
Review Comment:
Fixed UpgradeProgressTrackerIT in 6c7480c
##########
test/src/main/java/org/apache/accumulo/test/upgrade/UpgradeProgressTrackerIT.java:
##########
@@ -154,7 +153,7 @@ public void testGetInitial() throws KeeperException,
InterruptedException {
assertFalse(upgradeNodeExists());
assertThrows(NullPointerException.class, () ->
progressTracker.getProgress());
assertFalse(upgradeNodeExists());
- progressTracker.startOrContinueUpgrade();
+ progressTracker.continueUpgrade();
Review Comment:
Fixed UpgradeProgressTrackerIT in 6c7480c
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
