keith-turner commented on code in PR #5383:
URL: https://github.com/apache/accumulo/pull/5383#discussion_r2031701027
##########
server/manager/src/main/java/org/apache/accumulo/manager/Manager.java:
##########
@@ -328,8 +328,8 @@ synchronized void setManagerState(final ManagerState
newState) {
break;
case HAVE_LOCK:
if (isUpgrading()) {
+ upgradeCoordinator.continueUpgrade();
upgradeCoordinator.preUpgradeValidation();
Review Comment:
This reUpgradeValidation( check runs in the manager and can cause upgrade to
fail to start. This failure could also be detected on the command line,
letting a user know that the upgrade will fail. Not a change for this PR, was
wondering if it made even made sense to call this code in both places.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
