ctubbsii commented on code in PR #5383:
URL: https://github.com/apache/accumulo/pull/5383#discussion_r2031995209
##########
server/base/src/main/java/org/apache/accumulo/server/util/UpgradeUtil.java:
##########
@@ -48,6 +59,14 @@ static class Opts extends ConfigOpts {
description = "prepare an older version instance for an upgrade to a
newer non-bugfix release."
+ " This command should be run using the older version of software
after the instance is shut down.")
boolean prepare = false;
+
+ @Parameter(names = "--check",
+ description = "check that 'accumulo upgrade --prepare' was run on the
instance after it was shut down.")
+ boolean check = false;
Review Comment:
I think `--start`.
My line of thinking is:
I think of `upgrade --prepare` as a currently optional, but in future
mandatory, "stage 0". `upgrade --start` would be "stage 1", and starting the
manager "stage 2" to complete the upgrade. In Maven, the stage in the release
plugin after "prepare" is "perform", but that implies completion, rather than
the next stage, and you would still have to start the manager to complete the
upgrade. So, that's the basis for my suggesting `--start`. `--begin` is also
acceptable, but sounds too formal, and `--init` I think is not quite right (too
robotic sounding, and also technically not true, since `--prepare` is kind of
an initialize phase).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
