keith-turner commented on code in PR #5455:
URL: https://github.com/apache/accumulo/pull/5455#discussion_r2031590825


##########
shell/src/main/java/org/apache/accumulo/shell/commands/MergeCommand.java:
##########
@@ -95,11 +95,9 @@ public Options getOptions() {
         new Option("s", "size", true, "merge tablets to the given size over 
the entire table");
     forceOpt = new Option("f", "force", false,
         "merge small tablets to large tablets, even if it goes over the given 
size");
-    // Using the constructor does not allow for empty option
-    Option.Builder builder = Option.builder().longOpt("all").hasArg(false)

Review Comment:
   If want to avoid adding the `-a` option then maybe could keep this builder 
code as is and change the following code which is a bit further up in the class 
from
   
   ```java
       if (cl.hasOption(allOpt.getOpt())) {
         all = true;
       }
   ```
   
   to
   
   ```java
       if (cl.hasOption(allOpt.getLongOpt())) {
         all = true;
       }
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@accumulo.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to