keith-turner commented on code in PR #5472:
URL: https://github.com/apache/accumulo/pull/5472#discussion_r2042443885
##########
core/src/main/java/org/apache/accumulo/core/clientImpl/TabletServerBatchWriter.java:
##########
@@ -210,8 +210,7 @@ public long getTimeOut() {
public TabletServerBatchWriter(ClientContext context, BatchWriterConfig
config) {
this.context = context;
- this.executor = context.threadPools()
-
.createGeneralScheduledExecutorService(this.context.getConfiguration());
+ this.executor = context.getScheduledExecutor();
Review Comment:
> Do you think I should undo this change in TabletServerBatchWriter?
Seems like that would be safer, do not know of a specific problem but its
hard to conclude this task will always run when it needs to. Because a shared
pool at the context level processes task for all the data levels, seems like
there can be dependencies that may cause problems and potentially prevent a
metadata or root table update.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
