ctubbsii commented on code in PR #5473:
URL: https://github.com/apache/accumulo/pull/5473#discussion_r2047588326
##########
core/src/main/java/org/apache/accumulo/core/conf/Property.java:
##########
@@ -1063,6 +1063,14 @@ public enum Property {
"1.3.5"),
TABLE_ARBITRARY_PROP_PREFIX("table.custom.", null, PropertyType.PREFIX,
"Prefix to be used for user defined arbitrary properties.", "1.7.0"),
+
TABLE_COMPACTION_INPUT_DROP_CACHE_BEHIND("table.compaction.input.drop.cache",
"*",
+ PropertyType.STRING,
+ "Sets FSDataInputStream.setDropBehind(true) is set on compaction"
+ + " input streams for the specified type of files. The value of this
property is a comma-separated list of Accumulo"
+ + " file type prefixes ('A', 'C', 'F', 'I', and 'M'). The value '*'
can be used to"
+ + " specify all file types (default). When the input file prefix
matches a value in this list,"
Review Comment:
If the names of the enums are informative enough, that could be one way we
can separate the implementation details of the file naming conventions with the
user facing property configuration. I don't know if the names of these enums
are suitable, though... I would just like to separate the implementation detail
from the configuration property. The users should be configuring this property
for specific operations, not for specific filenames. (As in "setDropBehind when
doing operation X", not "setDropBehind when the file is named X").
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
