kevinrr888 opened a new pull request, #5510: URL: https://github.com/apache/accumulo/pull/5510
- Added early `return true` for all system tables for `TableOperations.exists()` - Move built in table check for `TableOperations.setTabletAvailability()` to be handled on server side instead of client side. Result is RPC now occurs for a built in table, and exception for calling `setTabletAvailability` on a built in table is changed from `IllegalArgumentException` to `AccumuloException`. All the other `TableOperations` that can't be called on a system table result in an `AccumuloException` if they are called on a system table, so this change keeps consistency with the other `TableOperations` - This commit additionally made it so that, for all `TableOperations`, the only validation done on the client side for a table is checking whether the argument is formatted correctly (via Validators.EXISTING_TABLE_NAME and Validators.NEW_TABLE_NAME) (e.g., table name is not blank, not too long, etc.). I believe this was the originally intention with https://github.com/apache/accumulo/issues/1953 I think this behavior of: - `IllegalArgumentException` - The table name doesn't make sense. Not expected format - `AccumuloException` - The table operation cannot be performed on that table Makes sense, and is now what occurs for applicable `TableOperations`. However, could argue that `IllegalArgumentException` makes sense for passing a system table, we should just be consistent across all `TableOperations` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
