keith-turner commented on code in PR #5537:
URL: https://github.com/apache/accumulo/pull/5537#discussion_r2075947537
##########
server/manager/src/main/java/org/apache/accumulo/manager/Manager.java:
##########
@@ -581,13 +560,14 @@ public void run() {
}
}
- private boolean shouldCleanupMigration(TabletMetadata tabletMetadata) {
+ boolean shouldCleanupMigration(TabletMetadata tabletMetadata) {
var tableState =
getContext().getTableManager().getTableState(tabletMetadata.getTableId());
var migration = tabletMetadata.getMigration();
Preconditions.checkState(migration != null,
"This method should only be called if there is a migration");
return tableState == TableState.OFFLINE ||
!onlineTabletServers().contains(migration)
- || tabletMetadata.getLocation().getServerInstance().equals(migration);
+ || (tabletMetadata.getLocation() != null
Review Comment:
This is the 2nd existing bug that was fixed in this change (the first was
fetching the location column when calling this). Was seeing an NPE here in the
logs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
