keith-turner commented on code in PR #5532:
URL: https://github.com/apache/accumulo/pull/5532#discussion_r2075966547
##########
core/src/main/java/org/apache/accumulo/core/spi/compaction/CompactionPlanner.java:
##########
@@ -94,6 +95,12 @@ public interface PlanningParameters {
*/
TableId getTableId();
+ /**
+ * @return the tablet for which a compaction is being planned
+ * @since 2.1.4
+ */
+ TabletId getTabletId();
Review Comment:
> I'm wondering if this should be a default method that returns null (not
throws a UnsupportedOperationException).
Returning null would not be the best long term behavior (like the behavior
we would want in 4.0). I was worried about adding this, but chose this
approach because a few lines up there is the following and I just followed its
precedent.
```java
/**
* @return The id of the namespace that the table is assigned to
* @throws TableNotFoundException thrown when the namespace for a table
cannot be calculated
* @since 2.1.4
*/
NamespaceId getNamespaceId() throws TableNotFoundException;
```
Whatever we do here, we probably need to do that consistently for all
changes like this in 2.1.4.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
