keith-turner commented on code in PR #5530:
URL: https://github.com/apache/accumulo/pull/5530#discussion_r2076269036


##########
server/manager/src/main/java/org/apache/accumulo/manager/Manager.java:
##########
@@ -1918,10 +1918,20 @@ public boolean isUpgrading() {
   }
 
   void initializeBalancer() {
-    var localTabletBalancer = 
Property.createInstanceFromPropertyName(getConfiguration(),
-        Property.MANAGER_TABLET_BALANCER, TabletBalancer.class, new 
TableLoadBalancer());
-    localTabletBalancer.init(balancerEnvironment);
-    tabletBalancer = localTabletBalancer;
+    try {
+      getContext().getPropStore().getCache().removeAll();

Review Comment:
   While running the new IT found this code would not see the new config that 
had been set by the code that calls this function.  So when the test changed 
the property, it would usually not pick up the new class name.  Had to add 
these two lines to make it work.  Seems like 
`getConfiguration().invalidateCache()` should be enough, but it was not.  Plan 
to open a follow on issue for `getConfiguration().invalidateCache()` not 
working reliably.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to